Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentError: comparison of String with Gem::Version failed #254

Open
styrken opened this issue Jun 1, 2022 · 2 comments
Open

ArgumentError: comparison of String with Gem::Version failed #254

styrken opened this issue Jun 1, 2022 · 2 comments
Labels

Comments

@styrken
Copy link
Contributor

styrken commented Jun 1, 2022

Check this out:

https://github.com/solidusio-contrib/solidus_subscriptions/blob/a487afef130ebf29679d864d08e83f6d2f8dd140/app/decorators/models/solidus_subscriptions/spree/order/finalize_creates_subscriptions.rb#L12

When booting rails application it fails. It can be fixed by changing the code to

if Gem::Version.new(::Spree.solidus_version) >= Gem::Version.new('3.2.0.alpha')

@styrken
Copy link
Contributor Author

styrken commented Jun 1, 2022

#255

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant