Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate compatibility and implementation of https://www.drupal.org/project/components and SDC #39

Open
ao5357 opened this issue May 4, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@ao5357
Copy link
Member

ao5357 commented May 4, 2023

In keeping with best practices in the Drupal community, determine if the frost theming model could benefit from the https://www.drupal.org/project/components module in any way, and if any of the components that have their own twig templates might likewise benefit from single-directory component architecture as explained at https://www.lullabot.com/articles/getting-single-directory-components-drupal-core

There are two possible outcomes of this ticket:

  1. A benefit is found that justifies refactoring the theme code to use components and perhaps SDC, in which case the assigned developer on the ticket opens a new ticket to complete the refactor
  2. No substantial benefit is found, and the assigned dev closes this ticket with a comment

If any proof-of-concept work is done on this ticket's feature branch, it could be used as the basis for further work, and a PR would be welcome (though we may switch the merge target to a non-main branch on the primary remote)

@ao5357 ao5357 added enhancement New feature or request help wanted Extra attention is needed labels May 4, 2023
@ao5357 ao5357 added this to the frost 1.4.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

1 participant