Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare two keys #125

Open
dignifiedquire opened this issue Jun 28, 2019 · 1 comment · Fixed by libp2p/go-openssl#1 · May be fixed by #126
Open

Compare two keys #125

dignifiedquire opened this issue Jun 28, 2019 · 1 comment · Fixed by libp2p/go-openssl#1 · May be fixed by #126

Comments

@dignifiedquire
Copy link

It would be great to have a Equal method to allow to compare keys, as currently they have to be serialized, allocating in go, making any comparisons very expensive.
@dignifiedquire
Copy link
Author

probably using https://www.openssl.org/docs/man1.0.2/man3/EVP_PKEY_cmp.html

dignifiedquire added a commit to dignifiedquire/openssl that referenced this issue Jun 28, 2019
@dignifiedquire
feat: add Equal method to compare keys
80f7894 
Closes spacemonkeygo#125
@dignifiedquire dignifiedquire linked a pull request Jun 28, 2019 that will close this issue
Open
@Stebalien Stebalien mentioned this issue Jun 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dignifiedquire