RFC: Increase Nokogiri::Gumbo::DEFAULT_MAX_ERRORS
to a positive number
#3248
flavorjones
announced in
RFCs
Replies: 2 comments
-
It's a holdover from Nokogumbo. See rubys/nokogumbo#78 for some discussion and rubys/nokogumbo#65 for the initial rationale. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Fascinating threads, thank you. I guess I'll think about this a bit more. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I'm not totally sure why this was initially set to 0 but I think it would be useful to:
There are more errors which were not recorded. Please set :max_errors to a larger number.
I would consider eventually setting the default to
-1
to capture all errors, but we should probably think about whether this is something that could be abused by an attacker via untrusted content.Beta Was this translation helpful? Give feedback.
All reactions