Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add array/base/unary3d-by #3219

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: add array/base/unary3d-by #3219

wants to merge 3 commits into from
+1,177 −0

Conversation

Neerajpathak07
Copy link
Contributor

Resolves #3173

Description

What is the purpose of this pull request?

This pull request:

  • adds implementation for array/base/unary3d-by

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 21, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
array/base/unary3d-by $\color{green}162/162$
$\color{green}+100.00\%$ 		$\color{green}12/12$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}162/162$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Nov 21, 2024
@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 21, 2024
@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

@Neerajpathak07 CI failures need to be addressed before this PR can be reviewed.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 21, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 21, 2024
@Neerajpathak07 Neerajpathak07 changed the title feat: add implementation for array/base/unary3d-by feat: add array/base/unary3d-by Nov 22, 2024
@Neerajpathak07
Copy link
Contributor Author

@kgryte Regarding the run_affected_examples they are running perfectly on my system when I tested them locally:-
unary3d-by

@Neerajpathak07
Copy link
Contributor Author

I'll resolve the lint errors and commit again.

kgryte
kgryte reviewed Nov 22, 2024
View reviewed changes
lib/node_modules/@stdlib/array/base/unary3d-by/README.md Outdated
var y = zeros3d( shape );
console.log( y );

unary23By( [ x, y ], shape, abs, accessor );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unary23By( [ x, y ], shape, abs, accessor );
unary3dBy( [ x, y ], shape, abs, accessor );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/unary3d-by
3 participants
@Neerajpathak07 @stdlib-bot @kgryte