Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add implementation for array/base/mskbinary5d #3198

Open
wants to merge 68 commits into
base: develop
Choose a base branch
from
Open

feat: add implementation for array/base/mskbinary5d #3198

wants to merge 68 commits into from
+1,158 −0

Conversation

AbhijitRaut04
Copy link
Contributor

Resolves #3180 .

Description

What is the purpose of this pull request?

This pull request:

  • implements the mskbinary4d package for masked binary operations in the array/base namespace.
  • and provides a 4D equivalent of the mskbinary4d package for binary callbacks using a mask array.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

AbhijitRaut04 and others added 30 commits October 21, 2024 00:21
@AbhijitRaut04
secant functionality added
020951d
@AbhijitRaut04
test cases checked
cd658c7
@AbhijitRaut04
huge_negative.json unformat
61dd8a5
@AbhijitRaut04
Examples fixed
1a3044c
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
4f9cfcd
@AbhijitRaut04
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
20d3800 
…o develop
@kgryte
Apply suggestions from code review
a7396d8 
Signed-off-by: Athan <[email protected]>
@AbhijitRaut04
Spacing conventions followed and required changes made
7a2c270
@AbhijitRaut04
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
d0ebc38 
…o develop
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
2733e3e
@AbhijitRaut04
necessary changes made
52900e0
@AbhijitRaut04
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
5ab6d39 
…o develop
@Planeshifter
chore: apply suggestions from code review
6f04f94 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
chore: update relative path
a630f41 
Signed-off-by: Philipp Burckhardt <[email protected]>
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
2cb28a7
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
c30cdec
@AbhijitRaut04
add c implementation for minmax
0735981
@AbhijitRaut04
example.out
0d34bb5
@AbhijitRaut04
add manifest.json
cbaa9a0
@AbhijitRaut04
pyp files added
89d15a4
@AbhijitRaut04
dependency resolved
64bb538
@AbhijitRaut04
removed minmax dependency
72be084
@AbhijitRaut04
return datatype changed
8b45444
@AbhijitRaut04
licensce years corrected
0339052
@AbhijitRaut04
years corrected
8f1f317
@AbhijitRaut04
unary to binary converted
6ca0a3f
@AbhijitRaut04
update
3346b22
@AbhijitRaut04
removed cephes
dd3e865
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
d5b8312
@AbhijitRaut04
manifest update
67e9010
AbhijitRaut04 and others added 23 commits November 16, 2024 00:21
@AbhijitRaut04
benchs examples
c89beac
@AbhijitRaut04
return changed to double instead double *
1f95c46
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
a4dbf3c
@AbhijitRaut04
native.js updated
6a0ad2f
@AbhijitRaut04
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
1ebac1d 
…o develop
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
8baa0ac
@stdlib-bot
Merge remote-tracking branch 'upstream/develop' into develop
d44c982
@AbhijitRaut04
changes made
ab4c30f
@AbhijitRaut04
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
480eca1 
…o develop
@AbhijitRaut04
changes made
ce381ba
@AbhijitRaut04
changes reverted
ea1137f
@AbhijitRaut04
native implementation updated
a84f7ee
@AbhijitRaut04
update native
42e7d33
@AbhijitRaut04
revrt
6770168
@AbhijitRaut04
revert
47fe186
@AbhijitRaut04
addon.c
0235838
@AbhijitRaut04
restored changes in develop branch
5618d1a
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
313a49b
@AbhijitRaut04
Merge branch 'stdlib-js:develop' into develop
27ab286
@AbhijitRaut04
Merge branch 'develop' of https://github.com/stdlib-js/stdlib into de…
beaf55e 
…velop
@AbhijitRaut04
add mskbinary5d implementation
e078499
@AbhijitRaut04
update relative path
63fd330
@AbhijitRaut04
spacing corrected
474bee3
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Nov 20, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 21, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
array/base/mskbinary5d $\color{green}182/182$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}182/182$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@AbhijitRaut04
Copy link
Contributor Author

@Planeshifter Please review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/mskbinary5d
4 participants
@AbhijitRaut04 @stdlib-bot @kgryte @Planeshifter