Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alias for network #1610

Open
janewang opened this issue Sep 17, 2024 · 3 comments
Open

Use alias for network #1610

janewang opened this issue Sep 17, 2024 · 3 comments
Assignees
@fnando

Comments

@janewang
Copy link
Contributor

janewang commented Sep 17, 2024 •
edited
Loading

What problem does your feature solve?

Simplification of the UI to use network alias everywhere

What would you like to see?

Simplify network config on stellar-cli: drop --rpc-url and --network-passphrase and require a network alias everywhere
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Sep 17, 2024
@janewang janewang moved this from Backlog (Not Ready) to Todo (Ready for Dev) in DevX Sep 17, 2024
@fnando
Copy link
Member

fnando commented Sep 17, 2024

I think I can squeeze this in for the protocol 22 release. 🤞

@leighmcculloch
Copy link
Member

Less manual entering of passphrases

Folks can already use --network everywhere and they are not required to enter network passphrases, so I think the "why" needs expanding on. What's the impact of this change?

This looks like a simplification of the UI.

@fnando
Copy link
Member

fnando commented Sep 17, 2024 •
edited
Loading

Yeah, I don't think manually entering network passphrases is the real issue. I'd say the goal it's to simplify the ui (only one way of accessing/providing network config) + codebase (flattening the network args brings more trouble than solution).

@fnando fnando mentioned this issue Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnando fnando

Labels
None yet
Projects
DevX
Status: Needs Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop --rpc-url and --network-passphrase. stellar/stellar-cli
3 participants
@fnando @leighmcculloch @janewang