Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript-eslint to v6 #138

Open
MaximeGrimler opened this issue Aug 3, 2023 · 2 comments
Open

Update typescript-eslint to v6 #138

MaximeGrimler opened this issue Aug 3, 2023 · 2 comments

Comments

@MaximeGrimler
Copy link

Is your feature request related to a problem? Please describe.
Would it be possible to update the dependencies of typescript-eslint from v5 to v6
v6 had been announced at beginning of July : https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/

Describe the solution you'd like
Update the dependency package version from v5 to v6

Thanks ! 😄

@jalovatt
Copy link

jalovatt commented Nov 6, 2023

Bumping this, as it can cause problems if you try to use the current version with Typescript 5.2.

@typescript-eslint v5 uses tsutils, which uses syntax that was deprecated in Typescript 5.0 and removed in 5.2. tsutils is dead, and @typescript-eslint have moved off of it for their v6.

Obvously users should be on top of making sure they update dependencies safely, things are still working, etc, but it took a good hour to track down why my lint command suddenly fell apart after updating TS this morning.

Updating this package to use @typescript-eslint v6 would be ideal, but if nothing else you folks may want to add a warning that this library is expressly not compatible with Typescript >= 5.2 until that issue is resolved.

@lesha1201
Copy link

@yannbf I can work on this and open a PR but I'm not sure if the project is actively maintained and what plans it has. Should I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants