Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Support for defaultProps will be removed #582

Closed
martinezguillaume opened this issue Jun 18, 2024 · 5 comments
Closed

Warning: Support for defaultProps will be removed #582

martinezguillaume opened this issue Jun 18, 2024 · 5 comments

Comments

@martinezguillaume
Copy link

Describe the bug
This line in the package @storybook/addon-ondevice-controls raises a warning

Warning: TextType: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

To Reproduce
Steps to reproduce the behavior:

  1. npx storybook@latest init in an existing project
  2. Run your storybook
  3. Go to "ADDONS" tab

Expected behavior
No warning at all 😎

Screenshots
Simulator Screenshot - iPhone 15 - 2024-06-18 at 21 50 20

@dannyhw
Copy link
Member

dannyhw commented Jun 18, 2024

ah I was hoping I could get v8 out before this became an issue haha, I can get out a fix soon for this thanks for flagging.

@ericwilsontruerx
Copy link

Is there a fix for this issue yet? I'm currently using version "^7.6.20"

@dannyhw
Copy link
Member

dannyhw commented Oct 10, 2024

@ericwilsontruerx i believe it should be fixed in v8, if not I can push a fix

@bbaoNg97
Copy link

Hi, is this fixed in v8?

@dannyhw
Copy link
Member

dannyhw commented Oct 18, 2024

yes its fixed in v8

@dannyhw dannyhw closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants