Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Sandbox vitest tests do not include symlinked stories #29203

Open
yannbf opened this issue Sep 25, 2024 · 0 comments
Open

Internal: Sandbox vitest tests do not include symlinked stories #29203

yannbf opened this issue Sep 25, 2024 · 0 comments
Labels
build Internal-facing build tooling & test updates

Comments

@yannbf
Copy link
Member

yannbf commented Sep 25, 2024 •
edited
Loading

Describe the bug

Seems like our Vitest sandbox tests are only testing the basic stories, and not any of the symlinked stories at all. I quickly checked that the behavior works in Vitest ~2.0.0 but does not in Vitest ~2.1.0.

Take a look in a recent run in next: https://app.circleci.com/pipelines/github/storybookjs/storybook/84147/workflows/ae66030f-9e87-494b-a0db-cd3016f2a198/jobs/708910
Notice that only the basic stories are tested. There are 8 tests in that run, it should be around 190.
image

To reproduce:

  • create a vite based sandbox
  • run yarn vitest
  • experience the issue
@yannbf yannbf added the build Internal-facing build tooling & test updates label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yannbf