You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have two different jobs called ResetWorkspace and Cleanup that do similar things, calling out to ResetWorkspaceService and CleanupService. These jobs are invoked by DSA, which in turn starts then via calls from accessionWF:reset-workspace and accessionWF:end-accession.
It may make sense to have a single job that combines the logic of these two cleanup steps, and then (1) invokes this single job from accessionWF:reset-workspace and (2) removes the invocation of the job from accessionWF:end-accession, so that there are no jobs being called from the last step in accessionWF.
Per Captioning work cycle planning meeting 2024-09-25: This warrants a quick check-in with the wider infra team about whether to proceed, and much (maybe most) of the work will be coordinating testing. Also, we think that maybe the retries (in DSA job?) will keep the race condition from bothering Andrew with failed workflow steps, but not totally sure about that?
The text was updated successfully, but these errors were encountered:
We currently have two different jobs called ResetWorkspace and Cleanup that do similar things, calling out to ResetWorkspaceService and CleanupService. These jobs are invoked by DSA, which in turn starts then via calls from accessionWF:reset-workspace and accessionWF:end-accession.
It may make sense to have a single job that combines the logic of these two cleanup steps, and then (1) invokes this single job from accessionWF:reset-workspace and (2) removes the invocation of the job from accessionWF:end-accession, so that there are no jobs being called from the last step in accessionWF.
Reasoning? See the logic here: sul-dlss/common-accessioning#1289 (comment)
Would also possibly require changes to dor-services-client if any endpoints change in DSA.
See also sul-dlss/common-accessioning#1322
Per Captioning work cycle planning meeting 2024-09-25: This warrants a quick check-in with the wider infra team about whether to proceed, and much (maybe most) of the work will be coordinating testing. Also, we think that maybe the retries (in DSA job?) will keep the race condition from bothering Andrew with failed workflow steps, but not totally sure about that?
The text was updated successfully, but these errors were encountered: