Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support installation of ziglang #515

Open
NobodyXu opened this issue Jun 8, 2024 · 0 comments
Open

Feature request: Support installation of ziglang #515

NobodyXu opened this issue Jun 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@NobodyXu
Copy link
Collaborator

NobodyXu commented Jun 8, 2024

My understanding of this action is that it does not do extra installs that might be required to make a tool work.
e.g. installing cargo-valgrind does not also install valgrind ; installing xbuild does not also install adb and other bits of llvm not present on the github runner.

It is up to the user of this action to install dependencies that are missing, and that way they can choose the version they want of those dependencies.

I would support adding an extra tool called "ziglang", which would be a special case also like "valgrind". We could support installing different versions from https://pypi.org/project/ziglang/#history - that looks like a reasonable approach, but Python wheels are a messy format for this given that zig is a single binary, and pip is slow. Importing the binary URLs from https://ziglang.org/download/index.json would be more in tune with the way this action works, allowing runtime verification of the checksums.

Originally posted by @jayvdb in #508 (comment)

@taiki-e taiki-e added the enhancement New feature or request label Jun 8, 2024
@jayvdb jayvdb mentioned this issue Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants