Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom delimiters for resource filtering #42

Open
seanf opened this issue Nov 4, 2016 · 1 comment
Open

Allow custom delimiters for resource filtering #42

seanf opened this issue Nov 4, 2016 · 1 comment

Comments

@seanf
Copy link

seanf commented Nov 4, 2016

One way to avoid the need for partially filtered resource files (#40) is mentioned in MRESOURCES-162. The maven-resources-plugin provides delimiters and useDefaultDelimiters to choose a different delimiter, but this isn't possible with takari resource filtering, because there seems to be no way of controlling the delimiters.
@seanf seanf changed the title Allow custom delimeters for resource filtering Allow custom delimiters for resource filtering Nov 4, 2016
seanf added a commit to zanata/zanata-platform that referenced this issue Nov 4, 2016
@seanf
Handle sample-projects with maven-resources-plugin again
51677d5 
We need partial resource filtering for files like glossary/pom.xml,
since some properties are only provided to the mvn invoked by the
test. See takari/takari-lifecycle#40 and
takari/takari-lifecycle#42.
seanf added a commit to zanata/zanata-platform that referenced this issue Nov 5, 2016
@seanf
Handle sample-projects with maven-resources-plugin again
2bfcf13 
We need partial resource filtering for files like glossary/pom.xml,
since some properties are only provided to the mvn invoked by the
test. See takari/takari-lifecycle#40 and
takari/takari-lifecycle#42.
seanf added a commit to zanata/zanata-platform that referenced this issue Nov 8, 2016
@seanf
Handle sample-projects with maven-resources-plugin again
ab746f3 
We need partial resource filtering for files like glossary/pom.xml,
since some properties are only provided to the mvn invoked by the
test. See takari/takari-lifecycle#40 and
takari/takari-lifecycle#42.
seanf added a commit to zanata/zanata-platform that referenced this issue Nov 8, 2016
@seanf
Handle sample-projects with maven-resources-plugin again
2765b60 
We need partial resource filtering for files like glossary/pom.xml,
since some properties are only provided to the mvn invoked by the
test. See takari/takari-lifecycle#40 and
takari/takari-lifecycle#42.
seanf added a commit to zanata/zanata-platform that referenced this issue Nov 9, 2016
@seanf
Handle sample-projects with maven-resources-plugin again
a007a86 
We need partial resource filtering for files like glossary/pom.xml,
since some properties are only provided to the mvn invoked by the
test. See takari/takari-lifecycle#40 and
takari/takari-lifecycle#42.
seanf added a commit to zanata/zanata-platform that referenced this issue Nov 11, 2016
@seanf
Handle sample-projects with maven-resources-plugin again
d8ccf1a 
We need partial resource filtering for files like glossary/pom.xml,
since some properties are only provided to the mvn invoked by the
test. See takari/takari-lifecycle#40 and
takari/takari-lifecycle#42.
@jakub-bochenski
Copy link

This is a migration blocker for me
Will take a stab at PR, any pointers would be welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanf @jakub-bochenski