Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests/integration tests #7

Open
tbillington opened this issue Jan 28, 2020 · 3 comments
Open

Add tests/integration tests #7

tbillington opened this issue Jan 28, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@tbillington
Copy link
Owner

No description provided.

@tbillington tbillington added the enhancement New feature or request label Jan 28, 2020
@tompscanlan
Copy link

Hi @tbillington I really like the project idea. Cleaning my code archive is something I do frequently, or I tend to run out of disk.

I think I saw #97 in the wild while playing around and didn't think anything of it until the issue was opened.

I'm new to rust, so really opening #98 as practice. Happy to discuss going this route or an alternative.

in #98, I've added a test filesystem, and a simple test that runs discover in the test filesystem and asserts the proper count of discovered projects.

If you hit a particular error, as in #97 , we can capture the important bit of the FS and store it as a test to work against. If it turns out to be nested projects, we just should be able to replicate that in this test structure.

Thoughts?

@tbillington
Copy link
Owner Author

It's looking good so far @tompscanlan , I commented in the PR with more details.

@tbillington
Copy link
Owner Author

Nested projects are a known issue #29. I have a larger refactor I'm slowly working on to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants