Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken 'reconnect' usage between tmt run invocations #3371

Open
lukaszachy opened this issue Nov 20, 2024 · 1 comment
Open

Broken 'reconnect' usage between tmt run invocations #3371

lukaszachy opened this issue Nov 20, 2024 · 1 comment
Labels
bug Something isn't working step | provision Stuff related to the provision step
Milestone

Comments

@lukaszachy
Copy link
Collaborator

It should possible to keep the rundir and use already provisioned machine in subsequent tmt run commands. But doing that hits the traceback for 'ssh' guests.

Reproducer:

$ cat plan.fmf
execute:
    how: tmt
    script: echo

$ tmt run --id BUG provision -h virtual
...
summary: 1 guest provisioned

$ tmt run --id BUG discover prepare
plan failed

The exception was caused by 1 earlier exceptions

Cause number 1:

    prepare step failed

    The exception was caused by 1 earlier exceptions

    Cause number 1:

Full traceback (TMT_SHOW_TRACEBACK=full) shows that assert fails:

            File /usr/lib/python3.13/site-packages/tmt/steps/provision/__init__.py, line 1469, in _ssh_master_socket_path
              assert isinstance(self.parent, tmt.steps.provision.Provision)

              self = <tmt.steps.provision.testcloud.GuestTestcloud object at 0x7f7a26529590>

assert isinstance(self.parent, tmt.steps.provision.Provision)

As in the tmt run --id BUG discover prepare the ssh connection is established during the prepare and thus the self.parent is tmt.steps.prepare.Prepare making the assert fail.

@lukaszachy lukaszachy added bug Something isn't working step | provision Stuff related to the provision step labels Nov 20, 2024
@psss psss added this to the 1.40 milestone Nov 20, 2024
@psss
Copy link
Collaborator

psss commented Nov 20, 2024

It would be good to get this fixed soon, proposing for 1.40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working step | provision Stuff related to the provision step
Projects
None yet
Development

No branches or pull requests

2 participants