Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable namespace management and augment namespace parameters when being managed #1761

Open
wondersd opened this issue Oct 6, 2023 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@wondersd
Copy link

wondersd commented Oct 6, 2023

Feature request

the namespace supplied in spec.targetNamespace is created and modified by the operator but there does not seem to be any dials for augmenting labels/annotations.

Would be nice to have both the ability to augment attributes of the namespace (labels/annotations), including ones that are included by the operator to date, and the ability to disable namespace creation/management by the operator to have it use a "provided" namespace

Use case

Our cluster expectations is that all pods are members of the linkerd service mesh, and we have specified running-in-environment-with-injected-sidecars = true

linkerd has two modes of running, either with a cni plugin or via an init container that modifies ip tables. The later is incompatible with the label pod-security.kubernetes.io/enforce: restricted that the operator adds on this namespace. There are also other annotations like linkerd.io/inject: enabled that would be nice to specify at the namespace level.

In other contexts i think its desirable to have that namespace created ahead of tekton pipelines being deployed into it. One case i can think of is addition of quota management or other namespaces governances that might be wanted ahead of having pipelines deployed into it to ensure that it follows the governances of that namespace

@wondersd wondersd added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 6, 2023
@jkandasa
Copy link
Member

jkandasa commented Oct 9, 2023

@wondersd If I understand correctly, you want to add your custom labels/annotations to the spec.targetNamespace via tektonConfig CR. Am I correct?

@wondersd
Copy link
Author

wondersd commented Oct 9, 2023

@jkandasa yes, and/or allow for disabling namespace management in the operator so that the namespace must be created and managed externally to the operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants