Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traffic agent should be able to preserve http header casing #2972

Open
tedchang77 opened this issue Jan 11, 2023 · 1 comment
Open

traffic agent should be able to preserve http header casing #2972

tedchang77 opened this issue Jan 11, 2023 · 1 comment
Labels
enterprise feature New feature or enhancement request

Comments

@tedchang77
Copy link

tedchang77 commented Jan 11, 2023

Please describe your use case / problem.
The traffic agent sidecar envoy proxy is converting http headers to lowercase which is breaking our application and downstream services that are case-sensitive.

Describe the solution you'd like
Introduce a traffic-manager flag that will preserve the HTTP header casing in the traffic-agent envoy sidecar. envoy has exposed this configuration in their configs: envoyproxy/envoy#14363

Describe alternatives you've considered
we have upstream services that we are propagating HTTP headers to. these services aren't owned by us, so we can't change them.
we looked at modifying/replacing the envoy config bootstrap-ads.pb in traffic agent sidecar using a configmap volumemount or an init-container, but it looks like this config is generated dynamically when the agent is started.

Versions (please complete the following information)

  • Output of telepresence version (just in case the feature exists in future versions)
    Enhanced Client: v2.9.5
    Root Daemon : v2.9.5
    User Daemon : v2.9.5
    Traffic Manager: v2.9.5
  • Kubernetes Environment and Version
    GKE Autopilot:
    Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.14", GitCommit:"3321ffc07d2f046afdf613796f9032f4460de093", GitTreeState:"clean", BuildDate:"2022-11-09T13:40:19Z", GoVersion:"go1.17.13", Compiler:"gc", Platform:"linux/amd64"}
    Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.7-gke.900", GitCommit:"e35c4457f66187eff006dda6d2c0fe12144ef2ec", GitTreeState:"clean", BuildDate:"2022-10-26T09:25:34Z", GoVersion:"go1.18.7b7", Compiler:"gc", Platform:"linux/amd64"}
    Additional context
    Add any other context about the feature request here.
    Without this feature, we cannot use telepresence.
@cindymullins-dw cindymullins-dw added the feature New feature or enhancement request label Jan 27, 2023
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and will be closed label Aug 16, 2024
@thallgren thallgren added enterprise and removed stale Issue is stale and will be closed labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise feature New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants