Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with rack 3.1 #162

Closed
keithlayne opened this issue Jul 5, 2024 · 2 comments
Closed

Incompatible with rack 3.1 #162

keithlayne opened this issue Jul 5, 2024 · 2 comments

Comments

@keithlayne
Copy link

In 3.1, rackup moved to a separate gem, so the server breaks on this line:

https://github.com/testdouble/cypress-rails/blob/main/lib/cypress-rails/server/puma.rb#L13

Rack::Handler is undefined in this case, but I confirmed changing that line to Rackup::Handler worked.

I don't know how or if you want to deal with this, from a quick look it appears that cypress-rails doesn't have an explicit dependency on rack.

Sorry, I don't have time to really look into this right now, for the moment I've just locked rack to 3.0, but wanted to let you know about it.

@krzysztofjablonski
Copy link
Contributor

I've created a PR #163 based on code from capybara: https://github.com/teamcapybara/capybara/blob/master/lib/capybara/registrations/servers.rb#L31

@rosston
Copy link
Member

rosston commented Sep 6, 2024

This should be fixed in 0.7.1 thanks to the PR from @krzysztofjablonski!

@rosston rosston closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants