We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
Using allowed_patterns in the fileignoreconfig section does not work with file names/paths that contain wildcards.
allowed_patterns
fileignoreconfig
To Reproduce
With .talismanrc config:
.talismanrc
fileignoreconfig: - filename: 'sub-folder/*.css' ignore_detectors: [filecontent] - filename: 'sub-folder/*.json' allowed_patterns: [dataKey]
Steps to reproduce the behavior:
mkdir -p sub-folder
echo '@keyframes{opacity:0;transform:scale(1)}' > sub-folder/test.css
echo '{"dataKey":"foobar"}' > sub-folder/test.json
talisman --pattern '**/*'
Only the css file is ignored, while the json file is still reported.
Expected behavior
The filename pattern for allowed_pattern definitions should be interpreted in the same way as for ignore_detectors.
filename
allowed_pattern
ignore_detectors
Desktop (please complete the following information):
Frank Seidel [email protected], Mercedes-Benz Tech Innovation GmbH Provider Information
The text was updated successfully, but these errors were encountered:
use existing path matching logic when filtering allowed patterns on f…
7ac7276
…ile configs (thoughtworks#414) - requires to change ChecksumCompare too, so it considers all ignore configs (and not only the first matching one)
Successfully merging a pull request may close this issue.
Describe the bug
Using
allowed_patterns
in thefileignoreconfig
section does not work with file names/paths that contain wildcards.To Reproduce
With
.talismanrc
config:Steps to reproduce the behavior:
mkdir -p sub-folder
echo '@keyframes{opacity:0;transform:scale(1)}' > sub-folder/test.css
echo '{"dataKey":"foobar"}' > sub-folder/test.json
talisman --pattern '**/*'
Only the css file is ignored, while the json file is still reported.
Expected behavior
The
filename
pattern forallowed_pattern
definitions should be interpreted in the same way as forignore_detectors
.Desktop (please complete the following information):
Frank Seidel [email protected], Mercedes-Benz Tech Innovation GmbH
Provider Information
The text was updated successfully, but these errors were encountered: