-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potentially invalid checksum in githook report #416
Comments
I just ran into this as well with 1.32.0. |
This previously closed issue may be related: #344 |
deepthirera
added a commit
to deepthirera/talisman
that referenced
this issue
May 21, 2024
…considered as different files
deepthirera
added a commit
to deepthirera/talisman
that referenced
this issue
Jun 3, 2024
…e special characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The proposed
.talismanrc
format of a--githook
report might contain checksums that have no effect when used in the.talismanrc
file, so the same finding is reported again on next run.Seems to happen with files whose name is used multiple times within the repository folder structure, typically readmes or scripts.
To Reproduce
When putting the reported
fileignoreconfig
section into a.talismanrc
file and runningtalisman --githook pre-commit
again, the same finding is reported.Expected behavior
The proposed format by Talisman to whitelist findings should work by simply copy & pasting.
Additional context
There is a workaround by creating the checksum value explicitly via
talisman --checksum
command, but the typical user would not be aware of that.Desktop (please complete the following information):
Frank Seidel [email protected], Mercedes-Benz Tech Innovation GmbH
Provider Information
The text was updated successfully, but these errors were encountered: