Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update version when pre-commit hook is invoked #434

Open
pornchanok-tw opened this issue Aug 31, 2023 · 3 comments
Open

Auto update version when pre-commit hook is invoked #434

pornchanok-tw opened this issue Aug 31, 2023 · 3 comments

Comments

@pornchanok-tw
Copy link

Describe the bug
Hi, there's a question from gordon-jetstar-tw and nueng-tw
According to this statement
image

Why there's no version update triggered when pre-commit hook triggered?

To Reproduce
Steps to reproduce the behavior:

  1. run ./.git/hooks/bin/talisman --version
    image

  2. run ./.git/hooks/bin/talisman --githook pre-commit
    image

  3. run ./.git/hooks/bin/talisman --version again. the version still remain the same
    image

Expected behavior
The version should be automatically updated to the latest version. (Now it's 1.31.0)

Desktop (please complete the following information):

  • Macbook Pro M1
  • OS: Macos ventura 13.5.1
@tinamthomas
Copy link
Collaborator

@pornchanok-tw could you verify that the TALSIMAN_HOME is configured to the same location (./.git/hooks/bin/talisman )

@dougalg-js-tw
Copy link

cc @gordon-jetstar-tw @nueng-tw

@dougalg-js-tw
Copy link

@tinamthomas this was not configured, but configuring it does not appear to resolve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants