-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Talisman fails silently if parts of the .talismanrc are not valid yaml #454
Comments
deepthirera
added a commit
to deepthirera/talisman
that referenced
this issue
Jun 19, 2024
deepthirera
added a commit
that referenced
this issue
Jul 19, 2024
deepthirera
added a commit
to deepthirera/talisman
that referenced
this issue
Jul 19, 2024
deepthirera
added a commit
to deepthirera/talisman
that referenced
this issue
Jul 19, 2024
deepthirera
added a commit
to deepthirera/talisman
that referenced
this issue
Jul 19, 2024
deepthirera
added a commit
that referenced
this issue
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
.talismanrc
is supposed to be a yaml file. However, the filename does not end in .yaml, certain editors may not detect it and use yaml settings, and additionally, yaml linters will not detect it by default to find errors.This can lead to silent failures - for example if a
tab
is added to one of the lines. Further lines in the file (such as custom_patterns) could be ignored, leading to password leakage.To Reproduce
Steps to reproduce the behavior:
git add .
and thentalisman -l debug --githook pre-commit
and confirm the secret is detected and the custom pattern was usedgit add .
and thentalisman -l debug --githook pre-commit
and confirm the secret no longer detectedExpected behavior
.talismanrc.yaml
file and perform some basic sanity checks on the file.talismanrc
should be renamed as.talismanrc.yaml
so it is detected by yamllinters and editors..talismanrc.yaml
should be updated to be proper yaml (with correct indenting)should be
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: