-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update socket types API to match std lib #1750
Comments
I checked the API of the socket types of the master branch oof UdpSocket:
Traits:
TcpStream:
Traits:
TcpListener:
UnixDatagram:
Traits:
UnixStream:
Traits:
UnixListener:
Traits:
Apart from the missing functions/traits that I listed above there are function on all sockets missing that in my opinion are pointless to implement for
I hope this little summary is somewhat helpful. |
Thanks @tglane
Cloning with Mio is a bad idea, so I don't think we should add these.
I/O safety traits are being added here: #1745.
This we can add.
No cloning, see above.
Being added in #1745.
These don't really work as we have an iterator that would return
No cloning.
I/O traits again.
Not sure about this, currently unstable so we'll wait and see.
Could look into these after #1749.
I think we can skip these nightly-only API, these have been unstable for years now.
No cloning.
More I/O traits.
Same as above, unstable and cloning API.
I/O traits.
Same as for
More I/O traits.
Again.
Very much so, thank you! TL;DR:
|
Correct me if I'm wrong here, but in the mentioned PR only the trait Should we wait wiith adding |
Good point.
Yes, in the (somewhat unlikely) case that the API changes in std lib. |
Postponing this until after a v1 since we can always add more API. |
Need to check if we're missing any API compared to the types found in the standard library.
The text was updated successfully, but these errors were encountered: