Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the actual error message on gRPC failure #414

Open
mdii opened this issue Sep 26, 2023 · 1 comment
Open

Include the actual error message on gRPC failure #414

mdii opened this issue Sep 26, 2023 · 1 comment

Comments

@mdii
Copy link

mdii commented Sep 26, 2023

Feature Request

Motivation

Currently when there is a gRPC error a tracing event is generated at the error level with the generic response failed message. We can see this event in the logs as well. However, the message is not informative and it hides the actual error.

Proposal

We need to modify DefaultOnFailure and GrpcErrorsAsFailures so that the error message and the status code are available in the on_failure() method.

@davidpdrsn
Copy link
Member

Please write a more helpful issue title.

@mdii mdii changed the title Improve Include the actual error message on gRPC failure Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants