Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tower_http::trace doc clarification regarding ingestion of parent spans from incoming requests #508

Open
lcmgh opened this issue Sep 5, 2024 · 2 comments

Comments

@lcmgh
Copy link

lcmgh commented Sep 5, 2024

Does https://docs.rs/tower-http/latest/tower_http/trace/index.html also take care of ingesting the parent span/trace id from incoming requests to basically enable cross-service tracing?

That is not clear to me when reading the docs.

@jplatte
Copy link
Collaborator

jplatte commented Sep 5, 2024

No, it doesn't.

@lcmgh
Copy link
Author

lcmgh commented Sep 5, 2024

okay, that's probably why https://github.com/davidB/tracing-opentelemetry-instrumentation-sdk/tree/main/tonic-tracing-opentelemetry exists

What I understand is that tower_http::trace exists to get request/response traces and tonic-tracing-opentelemetry crate exists to get the span connection to parent trace ids from incoming requests and not to log request/Response data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants