Make linenumbers relative to file #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebDieBln
force-pushed
the
MakeLinenumbersRelativeToFile
branch
from
6b45460
to
dcc4fb3
Compare
SebDieBln
force-pushed
the
MakeLinenumbersRelativeToFile
branch
from
94605d5
to
85e8889
Compare
SebDieBln
force-pushed
the
MakeLinenumbersRelativeToFile
branch
from
85e8889
to
11a1a9e
Compare
SebDieBln
force-pushed
the
MakeLinenumbersRelativeToFile
branch
2 times, most recently
from
52045fb
to
9b56c01
Compare
The respository name is currently saved in the 'path' column for comments. For subscriptions however it is stored in a separate column.
Until now it used the path to determine the repository.
SebDieBln
force-pushed
the
MakeLinenumbersRelativeToFile
branch
2 times, most recently
from
970ff60
to
b945f04
Compare
Remove the bogus line numbers and leave an explanation in the text of the comment.
The term "line number" is ambiguous because there is a difference between a line number "within the diff" and a line number "within a file".
Negative line numbers are used to indicate a comment that was placed on a line of the old file.
SebDieBln
force-pushed
the
MakeLinenumbersRelativeToFile
branch
from
b945f04
to
a123114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #67.
Comments to lines of a file are now referenced to the actual line in the file, not the line in the diff-view. If the comment is for a deleted line, the line-number within the old file is used and saved along with a minus-sign as a flag to indicate it is for the old file.
There is room for further improvement: