Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile on Ubuntu 24.04 #1131

Open
j1warren opened this issue Sep 15, 2024 · 1 comment
Open

Doesn't compile on Ubuntu 24.04 #1131

j1warren opened this issue Sep 15, 2024 · 1 comment

Comments

@j1warren
Copy link

see here
#45 (comment)

@j1warren
Copy link
Author

facebook/rocksdb@88edfbf
https://github.com/facebook/rocksdb/pull/12171/files

Fixed it with this in build/docker/bin/Dockerfile

# install rocksdb
RUN cd /opt && git clone -b $ROCKSDB_VERSION --depth 1 https://github.com/facebook/rocksdb.git
+RUN cd /opt/rocksdb && sed -i '8i #include <cstdint>' table/block_based/data_block_hash_index.h && sed -i '9i #include <cstdint>' util/string_util.h && sed -i '11i #include <cstdint>' include/rocksdb/utilities/checkpoint.h
+RUN cd /opt/rocksdb && CFLAGS=-fPIC CXXFLAGS="-fPIC -Wno-error=redundant-move" PORTABLE=$PORTABLE_ROCKSDB make -j 4 release
-RUN cd /opt/rocksdb && CFLAGS=-fPIC CXXFLAGS=-fPIC PORTABLE=$PORTABLE_ROCKSDB make -j 4 release
RUN strip /opt/rocksdb/ldb /opt/rocksdb/sst_dump && \
    cp /opt/rocksdb/ldb /opt/rocksdb/sst_dump /build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant