You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue describe possible improvements of monorepo tooling and CI:
1. Stop using script with : in workspace scripts. This is conflictin with both Yarn 3 and Nx conventions. We can't use nx run because it needs to be called in pattern nx run packageName:scriptName and when there is : in scriptName it will fail. It also causes problem because Yarn 3 considering these scripts as global scripts. (lint:js => lint-js, build:libs => build-libs etc.).
2. Replace lerna commands with simple nx run (this require point 1 to be done).
3. Use global script for tsc same as g:eslint
4. Remove "build:libs" step from Github validation workflow. Both type-check and test:unit has dependency on it defined thanks to Nx, so Nx will call it only when it's necessary. This is not big deal because if it's called second time it's cached anyway.
5. Improve Yarn cache - current cache is invalidated everytime when yarn.lock is changes and that is very often because also our internal packages dependencies are defined here since upgrade to Yarn 3. We probably don't need to invalidate cache at all. More info here Performance opportunity for yarn 3 cache actions/setup-node#325
6. Speed up code formatting with prettier - Nx probably could be configured to run formatting only affected files. This should save ~40s. https://nx.dev/nx/format-check
This issue describe possible improvements of monorepo tooling and CI:
:
in workspace scripts. This is conflictin with both Yarn 3 and Nx conventions. We can't usenx run
because it needs to be called in patternnx run packageName:scriptName
and when there is:
in scriptName it will fail. It also causes problem because Yarn 3 considering these scripts as global scripts. (lint:js => lint-js, build:libs => build-libs etc.).nx run
(this require point 1 to be done).tsc
same asg:eslint
Related to: #6095 #4936
The text was updated successfully, but these errors were encountered: