Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable -P:semanticdb:synthetics:on in sbt-typelevel-scalafix? #305

Open
armanbilge opened this issue Jun 15, 2022 · 2 comments
Open

enable -P:semanticdb:synthetics:on in sbt-typelevel-scalafix? #305

armanbilge opened this issue Jun 15, 2022 · 2 comments
Labels

Comments

@armanbilge
Copy link
Member

This is needed for some rules, but not all. Should we enable it by default? At the very least maybe expose a setting to make it easy to switch on. (And always the question: why doesn't sbt-scalafix do this itself?)

@rossabaker
Copy link
Member

What is the drawback? Compilation time?

@armanbilge
Copy link
Member Author

Maybe not even that. The semantic db docs say this for the option.

Specifies whether to save some of the compiler-synthesized code in the currently unspecified TextDocument.synthetics section (on for yes, off for no).

https://scalameta.org/docs/semanticdb/guide.html#scalac-compiler-plugin

That seems harmless enough?

I'm just confused/frustrated why we have to enable so much stuff that seems like it should be enabled in sbt-scalafix itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants