Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rails 7.2 #552

Open
pgwillia opened this issue Mar 6, 2024 · 1 comment
Open

Bump Rails 7.2 #552

pgwillia opened this issue Mar 6, 2024 · 1 comment

Comments

@pgwillia
Copy link
Member

pgwillia commented Mar 6, 2024

https://edgeguides.rubyonrails.org/7_2_release_notes.html

May be dependent on comfy.

@murny
Copy link
Collaborator

murny commented Aug 13, 2024

Looks like we can't do this until we migrate off of secrets

From https://edgeguides.rubyonrails.org/7_2_release_notes.html#railties-removals:

Remove deprecated Rails.application.secrets.

You can see this failing in the dependabot PR: https://github.com/ualbertalib/library-cms/actions/runs/10374144119/job/28720917903

I posted some ideas for doing this in the Jupiter Issue: ualbertalib/jupiter#3347

Either we need to go to credentials which replaced secrets (but this requires coordination with Neil and changing how we do things for deployments) or basically create our own "secrets" config for the time being, like using a simple config_for. Or maybe explore some other options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants