Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installs via environment files failing #779

Closed
ras44 opened this issue Jun 6, 2024 · 1 comment
Closed

installs via environment files failing #779

ras44 opened this issue Jun 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ras44
Copy link
Collaborator

ras44 commented Jun 6, 2024

Describe the bug

This is a follow up on the work being done in #778 to list and address a variety of ongoing issues related to the pre-defined environment files in envs/:

question re defining causalml version

  • should env files contain a relative reference to the current source? ... as shown in envs/environment-py39.yml:
    image

  • or a fixed version, as shown in envs/environment-py38.yml:
    image

  • I would vote in favor of a fixed version

    • follow up: should we update to the latest release 0.15.1 ?

pytest failures

See failure details at: https://github.com/ras44/causalml/actions/runs/9391720812/job/25864510171

  • pytest -vs tests/ --cov causalml/ fails for:
    • environment-py37.yml
      image
    • environment-py38.yml
      image
    • environment-py39.yml
      image

The failures in our Github workflows largely appear related to:
image

Building on other platforms like Ubuntu on Windows, we see other failures, likely related to the build environment and cython.

environment build failures re tensorflow dependencies

  • dependency issues in the tensorflow environments that look like:

image

To Reproduce
See example results of current build at:
https://github.com/ras44/causalml/actions/runs/9391720812/job/25864510171

Expected behavior
Successful builds for all included environment files.

Screenshots
N/A

Environment (please complete the following information):
See build logs

Additional context
N/A

@ras44 ras44 added the bug Something isn't working label Jun 6, 2024
@ras44 ras44 mentioned this issue Jun 6, 2024
10 tasks
@ras44
Copy link
Collaborator Author

ras44 commented Jun 10, 2024

closing, as we will likely remove support for environment files via #780

@ras44 ras44 closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant