Empty password reset email for unknown user culture

[callumbwhyte]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.0.3

Bug summary

When a user's culture is set to one that doesn't have translations in the CMS, there is no content for password reset emails sent for that user.

The email sent has [resetPasswordEmailCopySubject] as the subject and [resetPasswordEmailCopyFormat] as the body.

Unlike in the backoffice, there is no graceful fallback to another culture in this case.

Specifics

The ILocalizedTextService will return the translation key in square brackets if not set for the given culture.

The AuthenticationController doesn't check if the key exists for the given culture.

Steps to reproduce

• Create a user
• Set the user's culture to en-IE (for example)
• Request a password reset email via the login screen
• Email has only placeholder content

Expected result / actual result

If the selected culture does not have a translation for the resetPasswordEmailCopySubject and resetPasswordEmailCopyFormat keys it should at the very least fall back to English.

Even better, if the culture is a derivative of another it could fall back to the base culture – en-IE -> en, es-MX -> es, etc.

Regardless I would expect this to follow the same behaviour as in the backoffice, whereby the user always seems some kind of translated content.

Unsure if the ability to fallback should be added to the ILocalizedTextService (perhaps as an extension method), or the AuthenticationController just needs updating

[github-actions[bot]]

Hi there @callumbwhyte!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Zeegaan]

I looked into this, and while I do agree that in the case of reset password, we should probably fall back to the default language in all cases, so you at least reset your password 😅
I do however disagree with the other missing translations, I'd even argue that it makes it even harder to find out what translations you are missing.
Either way, its sounds more and more like a feature request than a bug to me, so I'm converting this to a discussion 🙈

[nul800sebastiaan]

We've always done a fallback to US-English if any of the translations were not available, even for let's say Norwegian, where we could fall back to Bokmål if Nynorsk is not available. It would make a lot of sense to fall back to Bokmål instead of going straight to English.

If you wanna know which languages are not available you could compare XML files as the easy path.