Cancelling a media upload with MediaSavingNotification still saves the file to disk

[DanDiplo]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.2.2

Bug summary

When using the MediaSavingNotification to cancel a file upload, the file doesn't appear in the media library but is still uploaded to the server and added to the Media folder.

Specifics

We've implemented a check to ensure Image uploads cannot be over a fixed size. If they are we cancel the operation using a notification. The check works and a notification is shown to the user saying the upload is too large - and the file doesn't show in the media library. However, it is still saved to disk in the Media folder. I believe that if you cancel the save operation then it should not save the media to disk and completely stop it being added.

Steps to reproduce

I've implanted the INotificationHandler<MediaSavingNotification>

    public void Handle(MediaSavingNotification notification)
    {
        foreach (var media in notification.SavedEntities)
        {
            CheckMediaSize(notification, media);
        }
    }
    
    private void CheckMediaSize(MediaSavingNotification notification, IMedia media)
    {
        var maxBytes = config.Value.MaxMediaFileSizeInBytes;
        var bytes = media.GetSizeInBytes();

        if (bytes > maxBytes)
        {
            var readableSize = FileHelper.GetHumanReadableFileSize(maxBytes);
            var reduction = FileHelper.GetHumanReadableFileSize(bytes - maxBytes);
            notification.Cancel = true;
            notification.CancelOperation(new EventMessage("Error", $"The file {media.Name} is over {readableSize} in size, which is too large. Please reduce it by {reduction} and try again.", EventMessageType.Error));
            logger.LogWarning("The file {fileName} was prevented from being saved to the Media section as it was over the maximum permitted size of {maxBytes} bytes ({MB}). You can increase this limit in PhCreative:Content:MaxMediaFileSizeInBytes field in appSettings.json", media.Name, maxBytes, readableSize);
        }
    }

Expected result / actual result

I'd expect cancelling the operation to prevent the file being saved to disk.

[github-actions[bot]]

Hi there @DanDiplo!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[anthony-3chillies]

Agree with @DanDiplo.

This should work as he said.

We need to set different file size limits for different file types, and this not working as above is very annoying.

[NguyenThuyLan]

Hi @DanDiplo , thank you for reporting this issue.
In v13, you can use this configuration to set the limit for requests
https://docs.umbraco.com/umbraco-cms/v/13.latest-lts/reference/configuration/maximumuploadsizesettings
But when if you want to set a size limit for each file type, you can use MediaSavingNotification custom handler as you did and wait for the server to clean the files up.
So, in v14, we could add a cancellable notification to the TemporaryFileService and this would be a new feature, so I will convert this issue to discussion.

[DanDiplo]

@NguyenThuyLan When you say "wait for the server to clean the files up" does that imply the file will eventually get removed by Umbraco or are you talking about some other manual clean up?

Are you saying it's not currently possible to stop a file being uploaded or to delete a file when using the MediaSavingNotification handler?