Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criterion and metric #155

Open
GerhardHNL opened this issue Sep 6, 2024 · 2 comments
Open

Criterion and metric #155

GerhardHNL opened this issue Sep 6, 2024 · 2 comments

Comments

@GerhardHNL
Copy link

Impacted sections

https://uncefact.github.io/spec-untp/docs/specification/DigitalProductPassport
https://uncefact.github.io/spec-untp/docs/specification/ConformityCredential
https://uncefact.github.io/spec-untp/docs/specification/DigitalFacilityRecord
https://uncefact.github.io/spec-untp/docs/specification/SustainabilityVocabularyCatalog

Issue Description

In short: my recommendation is to combine criterion and metric in one entity based on characteristics and name it “Metric Characteristic”. The characteristic the can be a Type and a Value (expressed in different data types, if needed). This would fit for all existing models as it is all about getting metrics values for a particular type.

In more detail: In the BSP vocabulary you will find the entities “sustainability characteristic” and “metric characteristic”. These entities are based on “characteristic” which holds attributes as 'type' and 'value' and more. The difference between “sustainability characteristic” and “metric characteristic” is that the latter one is neutral, context free. Using an entity based on “characteristic” allows us not only to specify quantitative measurements but also express qualitative aspects (e.g. a yes/no is often used in thresholds, the same for a score (high, low) in footprints, rankings. Anyway, Metric & Criterion should be a solid pair in one entity. I realize, naming relates to the definition of something. Today, you will find names as: aspect, indicator, criterion, requirement, attribute, metric, benchmark, standard, property, feature, threshold. A metric is quantifiable, usually a number or a ratio that can be objectively measured, specific as it focuses on a particular characteristic, attribute, or aspect and comparable as it allows for comparison between different data points. While many metrics involve numerical values and units of measure, some metrics are more abstract or qualitative and do not rely on standard units.

Remember to add relevant labels.

@onthebreeze
Copy link
Contributor

Thank you for this feedback.

One of the primary considerations when thinking about UNTP data modelling is whether the modelled thing is a uniquely identified node in a graph.

  • The UNTP Criterion is essentially a requirement or specification within a reference standard or regulation. For example an Australian standard for structural steel might specify a criterion such as minimum tensile strength for reinforcing bars. The criterion has a unique ID that is probably within the namespace of the reference standard or regulation. It is separate thing to any assessment of a specific product or facility against the criteria.
  • On the other hand, the UNTP Metric is not itself a uniquely identified thing. It is just a property of an assessment - eg assessment of a specific steel product against the Australian standard has a measured value that is held in the metric property of the assessment.

So I think it's not right to merge these two. Because one is a reference standard requirement (criterion) and the other is a property of an assessment against the standard.

Maybe there are better names for these things that might be less confusing - happy to hear suggestions on that - but I dont think they can be merged.

@GerhardHNL
Copy link
Author

GerhardHNL commented Sep 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants