Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the initial 0 length from VarZeroVec's representation #5516

Closed
Manishearth opened this issue Sep 6, 2024 · 2 comments · Fixed by #5601
Closed

Remove the initial 0 length from VarZeroVec's representation #5516

Manishearth opened this issue Sep 6, 2024 · 2 comments · Fixed by #5601
Assignees
@Manishearth
Labels
C-zerovec Component: Yoke, ZeroVec, DataBake
Milestone
ICU4X 2.0 Beta ⟨P1⟩

Comments

@Manishearth
Copy link
Member

VZV's representation is [length] [indices..] where the indices array is the indices of each element in the data segment. Index 0 is always 0, we don't need to store this and can remove it.

See also: #5240 and #5378
@Manishearth Manishearth added the C-zerovec Component: Yoke, ZeroVec, DataBake label Sep 6, 2024
@Manishearth Manishearth added this to the ICU4X 2.0 ⟨P1⟩ milestone Sep 6, 2024
@Manishearth
Copy link
Member Author

Fixing this is a good warm up for figuring out how much work is involved in fixing #5378

This was referenced Sep 9, 2024
Closed
Open
@sffc sffc removed their assignment Sep 17, 2024
@sffc
Copy link
Member

sffc commented Sep 17, 2024

@Manishearth is currently working on a PR.

@Manishearth Manishearth mentioned this issue Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
C-zerovec Component: Yoke, ZeroVec, DataBake
Projects
None yet
Milestone
ICU4X 2.0 Beta ⟨P1⟩
Development

Successfully merging a pull request may close this issue.

Remove the zero index from VarZeroVec Manishearth/icu4x
2 participants
@sffc @Manishearth