Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skia] Shapes arrange appear to be broken in certain cases #18265

Open
Youssef1313 opened this issue Sep 21, 2024 · 3 comments
Open

[Skia] Shapes arrange appear to be broken in certain cases #18265

Youssef1313 opened this issue Sep 21, 2024 · 3 comments
Assignees
@Youssef1313
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) project/shapes-brushes 🔶 Categorizes an issue or PR as relevant to shapes and brushes triage/untriaged Indicates an issue requires triaging or verification

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Sep 21, 2024 •
edited
Loading

Current behavior

Using Basic_Shapes sample, there is at least one broken scenario using Ellipse, UniformToFill, FixedWidthLarge.

Here is WinUI vs Skia comparison:

image

Somehow, vertical alignment isn't taking effect?

Simple repro:

<Grid Width="150" Height="150" BorderBrush="Green" BorderThickness="1">
<Ellipse Width="300" Stretch="UniformToFill" HorizontalAlignment="Left" VerticalAlignment="Bottom" Fill="Red" />
</Grid>

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@Youssef1313 Youssef1313 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. area/skia ✏️ Categorizes an issue or PR as relevant to Skia project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) project/shapes-brushes 🔶 Categorizes an issue or PR as relevant to shapes and brushes labels Sep 21, 2024
@Youssef1313
Copy link
Member Author

Youssef1313 commented Sep 21, 2024 •
edited
Loading

@MartinZikmund FYI, the popup opens in the wrong direction on Skia for this sample. Tracking in #18266

@Youssef1313 Youssef1313 mentioned this issue Sep 21, 2024
Open
@Youssef1313
Copy link
Member Author

I'll get this fixed in #18261

@Youssef1313
Copy link
Member Author

And for future reference, the fix is this:

image

@Youssef1313 Youssef1313 self-assigned this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) project/shapes-brushes 🔶 Categorizes an issue or PR as relevant to shapes and brushes triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Youssef1313