Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(skia): (partially) implement ShapeVisual.ViewBox and fix ShapeVisual clipping #18561

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat(skia): (partially) implement ShapeVisual.ViewBox and fix ShapeVisual clipping #18561

wants to merge 13 commits into from
+313 −114

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #18528

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels Oct 23, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18561/index.html

@jeromelaban
Copy link
Member

@ramezgerges this test looks odd:
https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=145111&view=ms.vss-test-web.build-test-results-tab&runId=3116491&resultId=101728&paneView=attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@Youssef1313 Youssef1313 Youssef1313 left review comments

@dr1rrb dr1rrb Awaiting requested review from dr1rrb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Desktop/Desktop WSL] Events Not Triggered When Using Image
4 participants
@ramezgerges @unodevops @jeromelaban @Youssef1313