Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: take the max property into consideration in the Progress component #899

Open
2 tasks done
MichelYpma opened this issue Nov 13, 2024 · 0 comments · May be fixed by #900
Open
2 tasks done

[Feature]: take the max property into consideration in the Progress component #899

MichelYpma opened this issue Nov 13, 2024 · 0 comments · May be fixed by #900

Comments

@MichelYpma
Copy link

MichelYpma commented Nov 13, 2024 •
edited
Loading

Describe the feature

The Progress component has support for a max property, but the shadcn-vue version uses a fixed max value of 100 while rendering. The max property should be taken into consideration and 100 should be the default when the optional max property is not there.

Additional information

  • I intend to submit a PR for this feature.
  • I have already implemented and/or tested this feature.
@MichelYpma MichelYpma linked a pull request Nov 13, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Take the max property into consideration in Progress MichelYpma/shadcn-vue
1 participant
@MichelYpma