Fix Hard-Coded Logic in Filetype Extension Conversion Script for Pipeline #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-nist
added
bug
Scope: CI/CD
aj-stein-nist
force-pushed
the
109-rev-5-baselines-reference-xml-version-of-the-catalog
branch
from
a243ddb
to
f80d7b4
Compare
|
Talked with Dave and will document evidence of in-place testing but not embed tests inline or separately add them and invoke them if we will not execute them as mandatory in CI/CD. Setting up CI/CD script testing and hardness would be a big lift to get it right. |
aj-stein-nist
added a commit
to aj-stein-nist/oscal-content-forked
that referenced
this pull request
Jun 10, 2022
aj-stein-nist
added a commit
to aj-stein-nist/oscal-content-forked
that referenced
this pull request
Jun 10, 2022
aj-stein-nist
added a commit
to aj-stein-nist/oscal-content-forked
that referenced
this pull request
Jun 13, 2022
|
Woops, it took a lot of CI/CD tweaks to confirm this was working on my fork and I couldn't figure out the weird errors in the GHA itself for the auto-commit features (it doesn't work well on forks). Finally, here is a reviewable example that the tweaks worked. |
david-waltermire
approved these changes
Jun 13, 2022
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 14, 2022
david-waltermire
pushed a commit
that referenced
this pull request
Jun 24, 2022
david-waltermire
pushed a commit
that referenced
this pull request
Jul 13, 2022
david-waltermire
pushed a commit
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Closes usnistgov/oscal-content#109, with explanation in usnistgov/oscal-content#109 (comment).
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.