-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbo prune does not respect yarn v1 lock file protocols split entries #8849
Comments
npm:
protocol split
npm:
protocol splitnpm:
protocol split entries
Important parts in the repro;
Currently blocking us from optimally using prune in our CI as we have to delete the pruned yarn.lock and generate a new yarn.lock based on the pruned repo. Slowing the pipeline a bit :( |
The same for the Basically all version fields starting with a protocol prefix should end up as separate entries in the yarn.lock |
npm:
protocol split entries
@chris-olszewski are you able to help me with this issue? yarn.lock entries with a protocol shouldn't be merged together (neither with one without a protocol) Probably something with; turborepo/crates/turborepo-lockfiles/src/yarn1/mod.rs Lines 148 to 155 in 6d4e655
Where it tries to check if anything matches with a protocol |
Verify canary release
Link to code that reproduces this issue
https://github.com/Netail/repro-yarn-lock
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
2.0.11
Describe the Bug
Pruned yarn.lock results in merging
npm:
prefixed versions & non-prefixed versionsExpected Behavior
Split yarn.lock entries starting with the
npm:
prefixTo Reproduce
Additional context
This issue got fixed in Yarn 1.22.22 with yarnpkg/yarn#9023.
A full thread on the issue; yargs/cliui#138
The text was updated successfully, but these errors were encountered: