Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitive optional dependencies resolution issue #91

Open
vietj opened this issue Nov 28, 2018 · 2 comments
Open

Transitive optional dependencies resolution issue #91

vietj opened this issue Nov 28, 2018 · 2 comments

Comments

@vietj
Copy link
Contributor

vietj commented Nov 28, 2018

It seems that optional=true dependencies that are transitively added force the resolution of the optional dependencies, e.g

vertx-junit5 -> vertx-rx-java2 -> vertx-micrometer-metrics (optional=true)

resolves vertx-micrometer-metrics jar

It can be reproduced by adding vertx-junit5 in the full stack json file and call resolve.

@cescoffier
Copy link
Member

I will have a look. Thanks for the reproducer!

@cescoffier
Copy link
Member

Ok, much more tricky than expected. We would need a "graph based resolver" and not the once we are using (tree-based). Maven has one, but right now we depend on Aether.

One solution would be to do the dependency resolution as a maven plugin and not trying to mimic Maven behavior.

anyway, this is going to be a big change, and won't be do-able before 4.0

@cescoffier cescoffier removed their assignment Dec 6, 2018
@cescoffier cescoffier added this to the 4.0.0 milestone Dec 6, 2018
@vietj vietj removed this from the 4.0.0 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants