Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct parameter handling in registerPeriodicSync function #23

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

simman
Copy link
Contributor

@simman simman commented Aug 19, 2024

This update ensures that the periodic sync registration is set up correctly.

  • Corrected the parameter order in the registerPeriodicSync function calls.
  • Ensured proper handling of Service Worker state changes and event listeners.

- Corrected the parameter order in the `registerPeriodicSync` function calls.
- Ensured proper handling of Service Worker state changes and event listeners.

This update ensures that the periodic sync registration is set up correctly.
@userquin
Copy link
Member

userquin commented Sep 4, 2024

closing this since period is defined outside the function

@userquin userquin closed this Sep 4, 2024
@simman
Copy link
Contributor Author

simman commented Sep 5, 2024

Can’t you verify if the current modifications are working?

@userquin userquin reopened this Sep 5, 2024
Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx ❤️

@userquin userquin merged commit 8d33933 into vite-pwa:main Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants