Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create an issue for commits that are already merged #26

Open
tesseralis opened this issue Feb 3, 2019 · 2 comments
Open

Don't create an issue for commits that are already merged #26

tesseralis opened this issue Feb 3, 2019 · 2 comments

Comments

@tesseralis
Copy link

Currently, chetsumi creates an issue for every item in the RSS feed, even those that are already merged in. For example: https://github.com/reactjs/ja.reactjs.org/issues?q=is%3Aissue+is%3Aclosed

All the [Doc] issues generated by che-tsumi are for commits that already existed when the repo was branched.

You can check that a commit already exists like I did here in my fork: https://github.com/tesseralis/che-tsumi/blob/master/lib/repository.js#L80

@re-fort
Copy link
Member

re-fort commented Feb 4, 2019

Nice feature😍
I'm thinking abount separating lib folder from che-tsumi and creating che-tsumi core.
After I do that, feel free to make a PR when you add a new feature!

@tesseralis
Copy link
Author

Will do! ^_^

@tesseralis tesseralis changed the title Don't create an issue for issues that are already merged Don't create an issue for commits that are already merged Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants