-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use well-defined npm script names instead of custom #303
Comments
@aentwist Thanks for the suggestion Maybe we could add Would you like to try and open a PR? |
Hi @cexbrayat, If this issue is still available, I think I could open a PR. However, I'm not sure if I understand correctly that you suggest we should keep the dev script, too? Wouldn't it be weird if a newly generated package.json contained two scripts for the same command? When I saw this issue, I thought about the following steps:
What do you think? |
I was thinking that it would be better to keep the existing ones to avoid all the tooling/docs/blog posts/books to reference commands that no longer exist. So I would:
|
OK, it's clear now. :) Then I'll take a look into it and open a PR soon, adding you as the reviewer if that's OK. |
I don’t receive |
Description
npm provides both
npm start
andnpm test
. Use these instead ofnpm run dev
andnpm run test:unit
.Considerations
Maybe there are different layers of tests. So then keep
test:unit
+ others, and add"test": "run-p test:unit ..."
The text was updated successfully, but these errors were encountered: