-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: markdown-it-attrs behaviour in pre wrapper plugin #3519
base: main
Are you sure you want to change the base?
fix: markdown-it-attrs behaviour in pre wrapper plugin #3519
Conversation
I managed to reproduce the issue that makes the tests fail, I'll do some more investigation soon. |
The The changes from the last commit resolve this issue by removing the invalid attribute from the |
45668e6
to
8f0b2a0
Compare
Implemented changes suggested by @TheNorthMemory and rebased onto main to resolve a merge conflict. |
/publish |
commit: |
@brc-dd I hosted a demo on stackblitz showing the changes in action. |
I noticed that the
markdown-it-attrs
did not work on fences with```md
. It was also mentioned in #826. The proposed changes could resolve this issue.I tested the changes on the following markdown and also checked for compatibility with the highligh lines syntax.
I also tested if disabling
markdown-it-attrs
still gives the expected behaviour.Let me know if changes are required or if more information is needed.
Resolves: #826