Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Ecommerce" prefixing #113

Closed
OR13 opened this issue Feb 17, 2021 · 18 comments
Closed

Remove the "Ecommerce" prefixing #113

OR13 opened this issue Feb 17, 2021 · 18 comments
Assignees

Comments

@OR13
Copy link
Collaborator

OR13 commented Feb 17, 2021

The vocab is for supply chain... we don't need "Ecommerce" prefixed everywhere.. and it makes things less reusable.

@Therecanbeonlyone1969
Copy link
Contributor

@OR13 ... happy to do that if we can standardize on the things that are must requirements for e-commerce which is currently represented in the VCs and evidence documents.

@OR13
Copy link
Collaborator Author

OR13 commented Mar 1, 2021

@Therecanbeonlyone1969 it might be worth taking some whole cohort time to discuss evidence in VCs, and generalization of vocab when we get our next chance.... ping @bumblefudge

@mprorock
Copy link
Collaborator

mprorock commented Mar 1, 2021 via email

@bumblefudge
Copy link
Contributor

Does "whole cohort" mean supply chain traceability subcohort or SVIP-wide cohort?

I think it might also be a topic for a CCG community call or DIF Interop WG, as I would be curious to poll implementers if there are best practices or conventions that might help?

@OR13
Copy link
Collaborator Author

OR13 commented Mar 1, 2021

^ yeah, larger crowd....

@OR13 OR13 self-assigned this Apr 28, 2021
@OR13
Copy link
Collaborator Author

OR13 commented Apr 28, 2021

@Therecanbeonlyone1969 any chance you can tackle this cleanup?

@Therecanbeonlyone1969
Copy link
Contributor

@OR13 yup ... will do a PR. What do we do for Orders and Invoices? We have conflicting schemas there. Wanna get on a call with interesting ppl and hash it out? cc @mprorock @bumblefudge

@OR13
Copy link
Collaborator Author

OR13 commented Jun 1, 2021

If we remove prefixes, then we need a base template, for shareable types and extensions.... blocked by base types?

@OR13
Copy link
Collaborator Author

OR13 commented Jun 1, 2021

blocked by #162

@OR13
Copy link
Collaborator Author

OR13 commented Jun 1, 2021

Proposal to add base types and removing prefixes in a single PR.

@OR13 OR13 assigned Therecanbeonlyone1969 and unassigned OR13 Jun 1, 2021
@TallTed
Copy link
Contributor

TallTed commented Jun 9, 2021

I agree that we don't need "Ecommerce" prefixed everywhere, because it does make things less reusable.

However, I don't believe that this (provenance-focused) vocab will only be used for supply chain, which I believe goes against the conversation in and around #153, even if that's the current intent or, I think more accurately, current focus, with broadened focus anticipated in future.

@OR13
Copy link
Collaborator Author

OR13 commented Aug 17, 2021

I think we can safely remove the prefix, without discussing other issues.

@OR13
Copy link
Collaborator Author

OR13 commented Aug 17, 2021

If there exist no conflict, remove the prefix.

if there exists a conflict, raise a separate issue.

@mprorock
Copy link
Collaborator

Per call: Can be revisted post YAML conversion now

@OR13
Copy link
Collaborator Author

OR13 commented Jan 18, 2022

we also have an issue with the evidence property. I suggest we just do our best to. simplify as much as we can.

@OR13
Copy link
Collaborator Author

OR13 commented Mar 29, 2022

@BenjaminMoe can you take a stab at this.

@BenjaminMoe
Copy link
Contributor

Yep! On it!

@BenjaminMoe
Copy link
Contributor

Addressed in #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants