-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GS1 Place with Schema.org Place #31
Comments
@mprorock @mkhraisha can one of you tackle this as a way of getting used to contributing here? |
@brianwmunz from our team is tacking this I believe as part of #32 - this is also related to #24 |
@mprorock @brianwmunz I'd happily tackle this next week if you would like or if you don't have the bandwidth. |
@mkhraisha that should be fine - may want to check with @brianwmunz (let me know if you need his work email - I believe he is using this model moving forward with our new schema objects, e.g. AgInspection and related |
@mprorock sorry I didn't follow your last comment, is @brianwmunz working on this already or should I tackle it? |
@mkhraisha is certainly handling a good example of this - but we likely need to do some more cleanup - and make the decision on "place" specifically. that one is likely worth keeping in as a vc example, even though it is redundant. all our commits going forward will be linking back out to gs1, schema.orgm etc. @OR13 are you still of the opinion we keep place in for example purposes? |
IMO, we should keep Place / PostalAddress / GeoCoordinates, because they are fundamental to traceability... but IMO we should not duplicate "Person" / "Organization" / "Product"... etc... at least for now. |
Sorry I missed some of your comments on here @mkhraisha but I've just submitted a PR for these changes. |
For any term where GS1 just copied schema.org, we should use schema.org definition instead.
For example:
https://www.gs1.org/voc/Place -> https://schema.org/Place
The text was updated successfully, but these errors were encountered: