Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflation of value #575

Closed
2 tasks
VladimirAlexiev opened this issue Sep 19, 2022 · 8 comments
Closed
2 tasks

conflation of value #575

VladimirAlexiev opened this issue Sep 19, 2022 · 8 comments
Assignees
Labels
1.0 version 1.0

Comments

@VladimirAlexiev
Copy link
Contributor

VladimirAlexiev commented Sep 19, 2022

Similar to #571, some schemas map several terms to schema:value, which makes it impossible to distinguish these values in RDF.
Eg OFBillOfLading:

  valuePerItem:
    title: Value Per Item
    description: Value Per Item
    type: string
    $linkedData:
      term: valuePerItem
      '@id': https://www.schema.org/value
  totalOrderValue:
    title: Total Order Value
    description: Total value of the order
    type: string
    $linkedData:
      term: totalOrderValue
      '@id': https://www.schema.org/value

then in the example:

    "valuePerItem": "500",
    "totalOrderValue": "1500",

This means that in RDF you cannot tell which number is which.

Tasks

@brownoxford
Copy link
Collaborator

Discussed on call, @VladimirAlexiev do you have a specific suggestion on what the values should be here?

@nissimsan
Copy link
Collaborator

Good catch. This becomes

    "https://www.schema.org/value": "500",
    "https://www.schema.org/value": "1500",

Not good!

@nissimsan
Copy link
Collaborator

Assigning @vivienfan , as this is your guys' schema.

@vivienfan
Copy link
Contributor

@vivienfan

@VladimirAlexiev
Copy link
Contributor Author

hi @vivienfan and @nissimsan and @brownoxford ,
You need to analyze the relevant Schema terms: Order, Offer, items, PriceSpecification (for more detailed modeling of prices, including subclasses CompoundPriceSpecification, DeliveryChargeSpecification, PaymentChargeSpecification, UnitPriceSpecification).

  • All of these use props price (numeric) and priceCurrency (ISO code): they don't use value
  • Order doesn't have any price fields but has acceptedOffer -> Offer, which itself has price fields. It means you must represent an order either using 2 nodes Order, Offer, or one node with these 2 types and a self-link acceptedOffer
  • Map totalOrderValue to Offer.price
  • How do you attach items to the order?
    • If you have individual items, link them with itemOffered and map valuePerItem to item.price
    • Otherwise map valuePerItem to Offer.priceSpecification[type=UnitPrice.price
  • Do you allow heterogeneous items in an order, and item multiples?

@BenjaminMoe BenjaminMoe assigned rhofvendahl and unassigned vivienfan Oct 24, 2023
@BenjaminMoe
Copy link
Contributor

@rhofvendahl to fix these in Agriculture schemas. @nissimsan and @BenjaminMoe to look at steel schemas.

This was referenced Oct 24, 2023
@mkhraisha mkhraisha added the 1.0 version 1.0 label Feb 20, 2024
@mkhraisha mkhraisha reopened this Feb 20, 2024
@mkhraisha
Copy link
Collaborator

Agriculture was closed with #895
Russel will be tackling steel as a solution to this issue.

@nissimsan
Copy link
Collaborator

The last should be fixed now with pr 950, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 version 1.0
Projects
None yet
Development

No branches or pull requests

7 participants