Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing lerna from this repo #587

Open
brownoxford opened this issue Oct 11, 2022 · 3 comments
Open

Investigate removing lerna from this repo #587

brownoxford opened this issue Oct 11, 2022 · 3 comments
Assignees

Comments

@brownoxford
Copy link
Collaborator

This repo has only one package and Lerna is probably not required.

@BenjaminMoe
Copy link
Contributor

BenjaminMoe commented Oct 11, 2022

The issue here is that npm t is running lerna run test, and I'm not sure what lerna is doing here. I know that this is generating the context, and then checking the signatures for the credentials.

I added the following snippet to the CI. Not sure if this is calling the tests again, and the issue was that we weren't throwing errors for schemas not being correct.

      - name: Jest
        run: cd packages/traceability-schemas && npm run test

@brownoxford
Copy link
Collaborator Author

We are still using lerna in package.json to run linting and testing

@nissimsan
Copy link
Collaborator

@brownoxford , any change you'd dive into this still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants