Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address JSON-LD semantic issue for Commercial Invoice #811

Open
BenjaminMoe opened this issue Jun 13, 2023 · 1 comment
Open

Address JSON-LD semantic issue for Commercial Invoice #811

BenjaminMoe opened this issue Jun 13, 2023 · 1 comment
Assignees
@BenjaminMoe
Labels
post-1.0 This is for issues that are important but should not block 1.0

Comments

@BenjaminMoe
Copy link
Contributor

From: #808

We deleted Proforma Invoice and added a boolean flag to Commercial Invoice Credential.
The boolean flag works in schema-land, but it's bad semantics.

The scope of this issue to propose a solution for how semantics could be better applied to the boolean flag.
@BenjaminMoe
Copy link
Contributor Author

Would like input from someone consuming the n-quad view of these credentials @nissimsan .

@mkhraisha mkhraisha added the post-1.0 This is for issues that are important but should not block 1.0 label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminMoe BenjaminMoe

Labels
post-1.0 This is for issues that are important but should not block 1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkhraisha @BenjaminMoe